Skip to content

Conversation

@dxFrankenWang
Copy link
Contributor

No description provided.

@genedna genedna requested a review from Copilot October 20, 2025 10:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the OpenTelemetry operator from version 0.91.0 to 0.91.1, including updates to the container image tag and endpoint configuration changes for instrumentation.

  • Updated Chart version and appVersion from 0.91.0 to 0.91.1
  • Updated manager image tag to a newer build (0.91.0)
  • Modified instrumentation endpoint configuration to use environment variable and updated port numbers

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
incubator/opentelemetry-operator/values.yaml Updated manager image tag to newer build
incubator/opentelemetry-operator/templates/instrumentation.yaml Changed endpoint configuration to use environment variable and updated ports from 55681 to 90/otlp
incubator/opentelemetry-operator/Chart.yaml Bumped chart version and appVersion to 0.91.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

image:
repository: ccr.ccs.tencentyun.com/tke-market/opentelemetry-operator
tag: 20250714-1608_apm_0.90.1_auto_6dc87fa2
tag: 20250912-1437_apm_0.91.0_auto_f5c0be5f
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image tag shows version 0.91.0 but the chart is being updated to 0.91.1. This version mismatch could cause confusion about which actual operator version is being deployed.

Suggested change
tag: 20250912-1437_apm_0.91.0_auto_f5c0be5f
tag: 20250912-1437_apm_0.91.1_auto_f5c0be5f

Copilot uses AI. Check for mistakes.
spec:
exporter:
endpoint: {{printf "%s:4317" (include "opentelemetry-operator.host" . ) | quote | trim}}
endpoint: {{.Values.env.ENDPOINT | quote | trim}}
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoint configuration now references .Values.env.ENDPOINT but this value is not defined in the provided values.yaml file. This will cause template rendering failures unless the environment variable is properly configured.

Suggested change
endpoint: {{.Values.env.ENDPOINT | quote | trim}}
endpoint: {{ .Values.env.ENDPOINT | default "" | quote | trim }}

Copilot uses AI. Check for mistakes.
@pavlelee
Copy link
Collaborator

lgtm

@pavlelee pavlelee merged commit a11c1ae into tkestack:main Oct 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants