Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crd proxy path #2326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: crd proxy path #2326

wants to merge 1 commit into from

Conversation

dantli
Copy link

@dantli dantli commented Nov 8, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
CustomResourceHandler user r.RequestURI as Path. It will get 404 response when RequestURI has params, like /api/v1/namespaces?limit=500. The correct Path is /api/v1/namespaces, not /api/v1/namespaces?limit=500

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant