Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for wallets #43

Merged
merged 3 commits into from
Oct 19, 2023
Merged

update docs for wallets #43

merged 3 commits into from
Oct 19, 2023

Conversation

timurnkey
Copy link
Contributor

Changes

  • updates policy language page to include new keyword: wallet
  • updates Activity Breakdown section of policy language page
  • updates API reference to include Wallets
  • re-organizes API reference. See below:

Screen Shot 2023-10-18 at 12 51 20 PM

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 0:55am

Comment on lines +85 to +113
| Resource Type | Action | Activity Type |
| --------------- | -------- | :----------------------------------------- |
| **ORGANIZATION** | CREATE | ACTIVITY_TYPE_CREATE_SUB_ORGANIZATION_V4 |
| **INVITATION** | CREATE | ACTIVITY_TYPE_CREATE_INVITATIONS |
| | DELETE | ACTIVITY_TYPE_DELETE_INVITATION |
| **POLICY** | CREATE | ACTIVITY_TYPE_CREATE_POLICY_V3 |
| | UPDATE | ACTIVITY_TYPE_UPDATE_POLICY |
| | DELETE | ACTIVITY_TYPE_DELETE_POLICY |
| **WALLET** | CREATE | ACTIVITY_TYPE_CREATE_WALLET |
| | CREATE | ACTIVITY_TYPE_CREATE_WALLET_ACCOUNTS |
| | EXPORT | ACTIVITY_TYPE_EXPORT_WALLET |
| **PRIVATE_KEY** | CREATE | ACTIVITY_TYPE_CREATE_PRIVATE_KEYS_V2 |
| | CREATE | ACTIVITY_TYPE_CREATE_PRIVATE_KEY_TAG |
| | UPDATE | ACTIVITY_TYPE_UPDATE_PRIVATE_KEY_TAG |
| | DELETE | ACTIVITY_TYPE_DISABLE_PRIVATE_KEY |
| | DELELE | ACTIVITY_TYPE_DELETE_PRIVATE_KEY_TAGS |
| | EXPORT | ACTIVITY_TYPE_EXPORT_PRIVATE_KEY |
| | SIGN | ACTIVITY_TYPE_SIGN_RAW_PAYLOAD_V2 |
| | SIGN | ACTIVITY_TYPE_SIGN_TRANSACTION_V2 |
| **USER** | CREATE | ACTIVITY_TYPE_CREATE_USERS_V2 |
| | CREATE | ACTIVITY_TYPE_CREATE_USER_TAG |
| | UPDATE | ACTIVITY_TYPE_UPDATE_USER |
| | UPDATE | ACTIVITY_TYPE_UPDATE_USER_TAG |
| | DELETE | ACTIVITY_TYPE_DELETE_USERS |
| | DELETE | ACTIVITY_TYPE_DELETE_USER_TAG |
| **CREDENTIAL** | CREATE | ACTIVITY_TYPE_CREATE_API_KEYS |
| | CREATE | ACTIVITY_TYPE_CREATE_AUTHENTICATORS_V2 |
| | DELETE | ACTIVITY_TYPE_DELETE_API_KEYS |
| | DELETE | ACTIVITY_TYPE_DELETE_AUTHENTICATORS |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome reorg 👏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this pulled from the version that's about to be deployed? Assuming yes :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually no 😓 here's the PR for mono: https://github.com/tkhq/mono/pull/2115

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get these into the release branch, but I don't think that should block

Copy link
Contributor

@andrewkmin andrewkmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@andrewkmin
Copy link
Contributor

looks like create sub org is defaulting to activity type v3, but intent type v4
image

@timurnkey
Copy link
Contributor Author

looks like create sub org is defaulting to activity type v3, but intent type v4 image

amazing catch ty!

Copy link
Contributor

@oliviathet oliviathet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants