Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image sizes #64

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Set image sizes #64

merged 4 commits into from
Nov 29, 2023

Conversation

oliviathet
Copy link
Contributor

@oliviathet oliviathet commented Nov 29, 2023

Changes

Docusaurus 2.1.0+ overrides CSS attributes like width and height with its own defaults. To actually enforce these, use the style attribute. (link)

Needed to fix this for the Wallet Export doc images. But also updated it for all other images to avoid confusion.

Tests

reviewed every image on vercel preview against docs.turnkey.com

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 3:39pm

@oliviathet oliviathet changed the title WIP: image size defaults Set image sizes Nov 29, 2023
@oliviathet oliviathet marked this pull request as ready for review November 29, 2023 15:39
Copy link
Contributor

@andrewkmin andrewkmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📸📸📸 looking great! ty for cleaning all the others up too 🥇

Copy link
Contributor

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@oliviathet oliviathet merged commit 5d3e852 into main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants