Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests with JSDOM and jest #3

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Add tests with JSDOM and jest #3

merged 7 commits into from
Oct 12, 2023

Conversation

r-n-o
Copy link
Collaborator

@r-n-o r-n-o commented Oct 11, 2023

I found a way to add tests without complicating the build too much. Everything stays in one file, still really easy to grasp. The difference is we have a namespace (TKHQ) where functions can be declared and accessible by tests.

Over time we should move everything to the TKHQ namespace, but I figured we need to start somewhere!

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f81ac68
Status: ✅  Deploy successful!
Preview URL: https://55980555.recovery-br3.pages.dev
Branch Preview URL: https://rno-tests.recovery-br3.pages.dev

View logs

@socket-security
Copy link

socket-security bot commented Oct 11, 2023

@socket-security
Copy link

socket-security bot commented Oct 11, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@r-n-o r-n-o requested a review from emostov October 11, 2023 15:56
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome

@r-n-o r-n-o merged commit 8d95662 into main Oct 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants