implement message channel #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-n-o
reviewed
Dec 11, 2024
r-n-o
reviewed
Dec 20, 2024
| ); | ||
| addDOMEventListeners(); | ||
|
|
||
| TKHQ.sendMessageUp("PUBLIC_KEY_READY", targetPubHex); |
There was a problem hiding this comment.
I'm worried that if this sendMessageUp function is called before TURNKEY_INIT_MESSAGE_CHANNEL is received (and thus, the channel set up), then the message will fail to be received on the other end (parent frame) because new SDKs won't listen for raw messages coming from postMessage anymore.
So it seems there's a bit of a race condition, and we should wait to receive "TURNKEY_INIT_MESSAGE_CHANNEL" before broadcasting "PUBLIC_KEY_READY"?
Another way to handle this is to broadcast PUBLIC_KEY_READY twice:
- leave this here the way you have it (for old SDKs)
- add a call to
sendMessageUp("PUBLIC_KEY_READY", targetPubHex)again right afterTKHQ.setParentFrameMessageChannelPortis called (so that new SDKs receive it as well)
Now that I'm writing this I think that's probably the cleanest option?
r-n-o
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.