add request id to iframe requests #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
force-pushed
the
andrew/request-idempotency
branch
from
e982756 to
fc38fa1
Compare
andrewkmin
force-pushed
the
andrew/request-idempotency
branch
from
fc38fa1 to
7042f2a
Compare
andrewkmin
force-pushed
the
andrew/request-idempotency
branch
from
442696a to
c43ab1e
Compare
r-n-o
reviewed
Jan 23, 2025
import/index.template.html
Outdated
| } | ||
|
|
||
| /** | ||
| * Function triggered when APPLY_SETTINGS event is received. | ||
| * For now, the only settings that can be applied are for "styles". | ||
| * Persist them in local storage so they can be applied on every | ||
| * page load. | ||
| * @param {string} settings: JSON-stringified settings | ||
| * @param {string} requestId | ||
| */ | ||
| async function onApplySettings(settings) { |
There was a problem hiding this comment.
I don't see a requestId param added here
r-n-o
approved these changes
Jan 23, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$title
SDK counterpart: tkhq/sdk#467
This mainly serves the case where there are concurrent, or serial, requests. Request IDs are used to disambiguate between multiple requests.