Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update federated passkey demo #118

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Update federated passkey demo #118

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1921a1b
update demo
octavien-mural Sep 15, 2023
121e333
add trailing comma
octavien-mural Sep 15, 2023
f355bd5
add trailing comma
octavien-mural Sep 18, 2023
8a2ff2e
prettify
octavien-mural Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion examples/with-federated-passkeys/src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ type privateKeyResult = {
};

// All algorithms can be found here: https://www.iana.org/assignments/cose/cose.xhtml#algorithms
// We only support ES256, which is listed here
// We only support ES256 and RS256, which are listed here
const es256 = -7;
const rs256 = -257;

// This constant designates the type of credential we want to create.
// The enum only supports one value, "public-key"
Expand Down Expand Up @@ -112,6 +113,11 @@ export default function Home() {
// https://www.w3.org/TR/webauthn-2/#sctn-sample-registration
const attestation = await getWebAuthnAttestation({
publicKey: {
authenticatorSelection: {
residentKey: "preferred",
requireResidentKey: false,
userVerification: "preferred"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @octavien-mural sorry for our linter being so pushy, but we may need another trailing comma here :)

to be safe, you can also try running pnpm -w prettier-all:write, in case anything else is missed (doesn't look like it though)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, just pushed again! I believe I have different prettier settings so I'm unable to run the command with the correct styling

},
rp: {
id: "localhost",
name: "Turnkey Federated Passkey Demo",
Expand All @@ -122,6 +128,10 @@ export default function Home() {
type: publicKey,
alg: es256,
},
{
type: publicKey,
alg: rs256,
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think prettier wants a trailing comma here. pnpm -w prettier-all:write

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed again!

],
user: {
id: authenticatorUserId,
Expand Down