UI components - Auth, Export, Import, and Demo #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@solana/[email protected], npm/@solana/[email protected] |
moe-dev
force-pushed
the
moe/ui-components
branch
2 times, most recently
from
3ed13ee to
4706a29
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
moe-dev
force-pushed
the
moe/ui-components
branch
3 times, most recently
from
6ffcc27 to
8434570
Compare
moe-dev
changed the title
moe-dev
force-pushed
the
moe/ui-components
branch
5 times, most recently
from
8d6214d to
e7455df
Compare
andrewkmin
reviewed
Dec 5, 2024
andrewkmin
reviewed
Dec 5, 2024
andrewkmin
reviewed
Dec 5, 2024
andrewkmin
reviewed
Dec 5, 2024
moe-dev
force-pushed
the
moe/ui-components
branch
from
0c79501 to
9831553
Compare
moe-dev
force-pushed
the
moe/ui-components
branch
4 times, most recently
from
58e39b4 to
a9b7ac0
Compare
moe-dev
force-pushed
the
moe/ui-components
branch
from
89a8e7c to
6bee93e
Compare
moe-dev
force-pushed
the
moe/ui-components
branch
from
6bee93e to
741dfa7
Compare
andrewkmin
approved these changes
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
andrewkmin
reviewed
Dec 16, 2024
moe-dev
force-pushed
the
moe/ui-components
branch
from
839e813 to
b453f76
Compare
moe-dev
force-pushed
the
moe/ui-components
branch
from
b453f76 to
974149b
Compare
andrewkmin
reviewed
Dec 16, 2024
| authIframeClient: any; | ||
| onValidateSuccess: (credentialBundle: any) => Promise<void>; | ||
| onResendCode: ( | ||
| type: "EMAIL" | "PHONE_NUMBER", |
There was a problem hiding this comment.
optional: can pull in enums here for consistency
| } | ||
|
|
||
| /** | ||
| * A provider component for dynamically applying and managing CSS custom properties (variables) as themes. |
andrewkmin
reviewed
Dec 17, 2024
| @@ -1070,7 +1069,7 @@ export default function Dashboard() { | |||
| × | |||
| </div> | |||
| <OtpVerification | |||
| type={emailInput ? "otpEmail" : "otpSms"} | |||
| type={emailInput ? "OTP_TYPE_EMAIL" : "OTP_TYPE_SMS"} | |||
There was a problem hiding this comment.
were you gonna use the enums here?
moe-dev
force-pushed
the
moe/ui-components
branch
from
8c1d6b1 to
ac98e27
Compare
| @@ -0,0 +1,30 @@ | |||
| import React, { createContext, useContext, useEffect } from "react"; | |||
There was a problem hiding this comment.
We should add "use client" here so devs don't need to wrap it or use "use client" in the root layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
How I Tested These Changes
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.