improve ci test stability #587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3341bd:
|
andrewkmin
force-pushed
the
andrew/viem-test-noop
branch
from
c1a9757 to
1dbb21d
Compare
andrewkmin
force-pushed
the
andrew/viem-test-noop
branch
from
358ed90 to
838fd8c
Compare
r-n-o
reviewed
Apr 10, 2025
.changeset/mighty-cycles-press.md
Outdated
Comment on lines
1
to
5
| --- | ||
| "@turnkey/eip-1193-provider": patch | ||
| --- | ||
|
|
||
| Tweak unit tests given expectation that the wallet ID used for tests will have 2 associated addresses |
There was a problem hiding this comment.
Nit: if it's a test-only change and doesn't impact the code that our customers consume whatsoever there's no need for a changelog entry 💅
There was a problem hiding this comment.
sahweet! removed :)
turnekybc
approved these changes
Apr 10, 2025
andrewkmin
force-pushed
the
andrew/viem-test-noop
branch
from
597ba49 to
a3341bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
$title
Viem tests were very unstable in CI, particularly due to the ERC721 case. Specifically, there were instances where there would be EVM collisions due to the ERC721 contract being deployed, deterministically, to the same address each time. (address and nonce are factors in determining the contract address. You cannot pass a
saltduring contract deployment using viem at this time)This PR aims to improve test stability by:
Interestingly, these race conditions do not happen locally.
If I were to test something else out, there are the following options:
How I Tested These Changes
local, CI
Did you add a changeset?
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.