bump go-sdk #47
Merged
bump go-sdk #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timurnkey
commented
Nov 1, 2023
|
|
||
| for i, s := range activitiesListStatus { | ||
| if s == Help { | ||
| Output(models.ActivityStatuses()) | ||
| Output(models.ActivityStatusEnum) |
There was a problem hiding this comment.
I don't love the name XEnum to represent a slice... but I didn't want to heavily modify the template. LMK if this is too bothersome
timurnkey
force-pushed
the
tim/bump-go-sdk
branch
from
1f336de to
741b668
Compare
r-n-o
approved these changes
Nov 2, 2023
Comment on lines
50
to
58
| case "created": | ||
| activitiesFilter[i] = models.V1ActivityStatusACTIVITYSTATUSCREATED | ||
| activitiesFilter[i] = models.ActivityStatusCreated | ||
| case "pending": | ||
| activitiesFilter[i] = models.V1ActivityStatusACTIVITYSTATUSPENDING | ||
| activitiesFilter[i] = models.ActivityStatusPending | ||
| case "completed": | ||
| activitiesFilter[i] = models.V1ActivityStatusACTIVITYSTATUSCOMPLETED | ||
| activitiesFilter[i] = models.ActivityStatusCompleted | ||
| case "failed": | ||
| activitiesFilter[i] = models.V1ActivityStatusACTIVITYSTATUSFAILED | ||
| activitiesFilter[i] = models.ActivityStatusFailed | ||
| case "consensus": |
There was a problem hiding this comment.
Oh man oh man oh man! Looking much better 😻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation (Problem vs. Solution)
💅
Changes
Follow-Ups