Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nproc: add page #2263

Merged
merged 2 commits into from
Sep 2, 2018
Merged

nproc: add page #2263

merged 2 commits into from
Sep 2, 2018

Conversation

sbrl
Copy link
Member

@sbrl sbrl commented Aug 26, 2018

I think this is linux-specific, but I don't have a Mac to test on :P

For #2213.


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@sbrl sbrl added the new command Issues requesting creation of a new page. label Aug 26, 2018
@tldr-bot
Copy link

The build for this PR has failed with the following error(s):

pages/linux/nproc.md:3: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


`nproc --all`

- If possible, subtract a given number of units from the returned value:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious to know why would this flag be helpful ? Can I not subtract the result anyways ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but in a script you'd have to ensure that you don't go below 1 with some fiddly nonsense - which this does automagically for you :P

@agnivade agnivade merged commit c29f156 into master Sep 2, 2018
@agnivade agnivade deleted the page-nproc branch September 2, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants