Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join: add page #2288

Merged
merged 2 commits into from
Sep 2, 2018
Merged

join: add page #2288

merged 2 commits into from
Sep 2, 2018

Conversation

mfrw
Copy link
Member

@mfrw mfrw commented Sep 1, 2018

Closes #1622, #1623
Updates #2213


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Thanks, @mfrw 😺

@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Sep 2, 2018

`join {{file1}} {{file2}}`

- Join filed3 of file1 with field1 of file2:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo with filed > field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks...

Copy link
Member

@owenvoke owenvoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@owenvoke owenvoke merged commit e97efdf into tldr-pages:master Sep 2, 2018
@mfrw mfrw deleted the joinagain branch September 6, 2018 14:53
@sbrl sbrl mentioned this pull request Sep 7, 2018
@bl-ue bl-ue changed the title join: add page (#1622) join: add page Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants