Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users: add page #2328

Merged
merged 2 commits into from
Sep 13, 2018
Merged

users: add page #2328

merged 2 commits into from
Sep 13, 2018

Conversation

owenvoke
Copy link
Member

Part of #2213


  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@owenvoke owenvoke added the new command Issues requesting creation of a new page. label Sep 12, 2018
@@ -0,0 +1,11 @@
# users

> Display a list of logged in users.
Copy link
Member

@mfrw mfrw Sep 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about ..
Lists the login names of the users currently on the system, in sorted order.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "logged in users" is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a bit too verbose, @mfrw. If possible, we prefer more concise descriptions as opposed to longer ones as they're easier to understand quickly :-)


`users`

- Display a list of logged in users according to a specific file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "according to a file" mean ? What does the file specify ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can specify a custom file. By default it checks /var/run/utmp. But there's also /var/log/wmtp which is a historical dump of utmp. And btmp which displays failed login attempts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. I thought it will always show the current logged in users. Perhaps we can mention "/var/log/wmtp" instead of path/to/file ? That may make things more clear.

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! Thanks again, @pxgamer 😺

@agnivade agnivade merged commit 74eb06f into tldr-pages:master Sep 13, 2018
@owenvoke owenvoke deleted the feature/users branch September 13, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants