Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logname: add page #2399

Merged
merged 2 commits into from
Oct 8, 2018
Merged

logname: add page #2399

merged 2 commits into from
Oct 8, 2018

Conversation

ckauf
Copy link
Contributor

@ckauf ckauf commented Oct 5, 2018

  • The page (if new), does not already exist in the repo.

  • The page (if new), has been added to the correct platform folder:
    common/ if it's common to all platforms, linux/ if it's Linux-specific, and so on.

  • The page has 8 or fewer examples.

  • The PR is appropriately titled:
    <command name>: add page for new pages, or <command name>: <description of changes> for pages being edited.

  • The page follows the contributing guidelines.

@ckauf
Copy link
Contributor Author

ckauf commented Oct 5, 2018

This is for issue #2213

@@ -0,0 +1,7 @@
# logname

> Shows the users login name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps user's instead of users would read better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Done that.


> Shows the users login name.

- Display login user name:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps Display the currently logged in user's name would read better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Done that.

@mfrw mfrw added the new command Issues requesting creation of a new page. label Oct 6, 2018
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @ckauf 😺

@owenvoke owenvoke merged commit c7dd5f5 into tldr-pages:master Oct 8, 2018
@ckauf ckauf deleted the logname branch October 11, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants