Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: add page #2918

Merged
merged 17 commits into from
Apr 16, 2019
Merged

script: add page #2918

merged 17 commits into from
Apr 16, 2019

Conversation

lbonanomi
Copy link
Contributor

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

schneiderl
schneiderl requested changes Apr 15, 2019
View reviewed changes
Copy link
Collaborator

@schneiderl schneiderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

First of all thank you for your PR.
I have just left a few comments with my opinion. Can you take a look and check if you agree with them?

Thanks a lot.

pages/linux/script.md Outdated Show resolved Hide resolved
pages/linux/script.md Outdated Show resolved Hide resolved
pages/linux/script.md Outdated Show resolved Hide resolved
schneiderl and others added 3 commits April 15, 2019 15:24
@schneiderl @lbonanomi
Update pages/linux/script.md
6041ebb 
Agree

Co-Authored-By: lbonanomi <[email protected]>
@schneiderl @lbonanomi
Update pages/linux/script.md
35bd281 
Agree

Co-Authored-By: lbonanomi <[email protected]>
@schneiderl @lbonanomi
Update pages/linux/script.md
eec7eaf 
Co-Authored-By: lbonanomi <[email protected]>
@sbrl sbrl added the new command Issues requesting creation of a new page. label Apr 15, 2019
sbrl
sbrl reviewed Apr 15, 2019
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @lbonanomi! I've left some comments below for you to review.

pages/linux/script.md Outdated Show resolved Hide resolved
pages/linux/script.md Outdated Show resolved Hide resolved
pages/linux/script.md Outdated Show resolved Hide resolved
pages/linux/script.md Outdated Show resolved Hide resolved
pages/linux/script.md Outdated Show resolved Hide resolved
sbrl and others added 5 commits April 15, 2019 16:24
@sbrl @lbonanomi
Update pages/linux/script.md
5f0cd88 
Sorry, still puzzling-out the formatting.

Co-Authored-By: lbonanomi <[email protected]>
@sbrl @lbonanomi
Update pages/linux/script.md
28220bd 
Perfect!

Co-Authored-By: lbonanomi <[email protected]>
@sbrl @lbonanomi
Update pages/linux/script.md
03598c3 
Co-Authored-By: lbonanomi <[email protected]>
@sbrl @lbonanomi
Update pages/linux/script.md
a4221c0 
Co-Authored-By: lbonanomi <[email protected]>
@sbrl @lbonanomi
Update pages/linux/script.md
690f33b 
Co-Authored-By: lbonanomi <[email protected]>
schneiderl
schneiderl reviewed Apr 15, 2019
View reviewed changes
pages/linux/script.md Outdated Show resolved Hide resolved
sbrl
sbrl approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lbonanomi 😺

I've made a teensy grammatical fix, if that's ok?

mebeim
mebeim approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the page @lbonanomi 🙂

@schneiderl schneiderl merged commit 80abec2 into tldr-pages:master Apr 16, 2019
@lbonanomi
Copy link
Contributor Author

Thank you for your endurance everyone!

@lbonanomi lbonanomi deleted the script branch April 18, 2019 00:42
@lbonanomi lbonanomi mentioned this pull request Apr 18, 2019
Merged
5 tasks
@lbonanomi
Copy link
Contributor Author

This PR is in support of #2214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrl sbrl sbrl approved these changes

@schneiderl schneiderl schneiderl approved these changes

@mebeim mebeim mebeim approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lbonanomi @sbrl @schneiderl @mebeim