-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runcon: add page #3297
runcon: add page #3297
Conversation
Per issue tldr-pages#2213, adding runcon
accidentally added a bad character
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
fix typo
The build for this PR has failed with the following error(s):
Please fix the error(s) and push again. |
dang trailing spaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new page, @tonytheleg ! I've left some comments below for you to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tonytheleg!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've fixed the page since it has been sitting here for a while. I've also dismissed @agnivade's review since I've addressed his comment, but he's unfortunately currently locked out of his GitHub account. It looks good to merge to me, what do you guys think?
Merging since this already has 4 approvals (+ 1 from @agnivade via Gitter). |
Nice one guys, this PR closes #2213 |
Woah really? Didn't notice, nice! 🚀 |
Per issue #2213, adding runcon
common/
,linux/
, etc.)