contacts: improve +sane-contact sanity checks

tloncorp · Oct 14, 2024 · a6aca98 · a6aca98
1 parent d8ffc6c
commit a6aca98
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/desk/lib/contacts.hoon b/desk/lib/contacts.hoon
@@ -161,6 +161,9 @@
 ::
 ::  - restrict size of the jammed noun to 10kB
 ::  - prohibit 'data:' URLs in image data
+::  - nickname and bio must be a %text
+::  - avatar and cover must be %look
+::  - groups must be a %set of %flags
 ::
 ++  sane-contact
   |=  con=contact
@@ -202,6 +205,16 @@
           =('data:' (end 3^5 u.cover))
       ==
     |
+  ?.  (~(typ cy con) %groups %set)  |
+  =+  groups=(~(get cy con) %groups %set)
+  ::  verifying the type of the first set element is enough,
+  ::  set uniformity is verified by +soft above.
+  ::
+  ?:  ?&  ?=(^ groups)
+          ?=(^ u.groups)
+          !?=(%flag -.n.u.groups)
+      ==
+    |
   &
 ::  +do-edit: edit contact
 ::