reel: fixing meta and url scries, token rotation, and extra metadata #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
approved these changes
Sep 9, 2024
| ``reel-metadata+!>(metadata) | ||
| :: | ||
| [%x any %token-url token=*] | ||
| =/ =token:reel (crip (join '/' token.pole)) | ||
| =/ =token:reel (crip +:(spud token.pole)) |
There was a problem hiding this comment.
Is this meaningfully different from the +join implementation?
There was a problem hiding this comment.
this was giving me errors I think? don't quite remember
Co-authored-by: fang <[email protected]>
…nto hm/small-reel-fixes
Fang-
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OTT, we weren't handling the grabbing the ID from the path correctly in the URL scries, and the metadata scry needed to be split between old and new versions. We previously weren't allowing you to rotate a particular group's token/metadata. This now correctly deletes the old data from the provider and gives new data, receiving a new token. There was also a small error in the set-ship thread where it had an extra slash. Finally we needed to include more metadata in the fields for invites and the DM we want to send.