Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contacts: implement activity #297

Merged
merged 2 commits into from
Nov 21, 2024
Merged

contacts: implement activity #297

merged 2 commits into from
Nov 21, 2024

Conversation

mikolajpp
Copy link
Collaborator

@mikolajpp mikolajpp commented Nov 13, 2024

Send %contact activity on contact book updates.
Fixes TLON-3176

Copy link

linear bot commented Nov 13, 2024

@mikolajpp mikolajpp marked this pull request as ready for review November 20, 2024 04:18
@mikolajpp mikolajpp requested review from Fang- and arthyn November 20, 2024 04:18
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small stuff, but looks good otherwise. (:

desk/app/contacts.hoon Outdated Show resolved Hide resolved
desk/app/contacts.hoon Show resolved Hide resolved
desk/app/contacts.hoon Outdated Show resolved Hide resolved
desk/lib/contacts.hoon Outdated Show resolved Hide resolved
@mikolajpp mikolajpp force-pushed the mp/contacts-activity branch from e3ae47d to c3dd9f1 Compare November 20, 2024 14:35
@mikolajpp mikolajpp force-pushed the mp/contacts-activity branch from c3dd9f1 to 0889599 Compare November 20, 2024 14:36
Copy link
Member

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mikolajpp mikolajpp merged commit 781d87a into develop Nov 21, 2024
1 check passed
@mikolajpp mikolajpp deleted the mp/contacts-activity branch November 21, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants