Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine manage channels screen #4319

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

patosullivan
Copy link
Member

@patosullivan patosullivan commented Jan 8, 2025

fixes tlon-3340

This refines the manage channels screen to:

  • use arrows rather than drag and drop
  • match (as closely as we can for now) the new ochre design
  • look less weird on desktop
  • work reliably

It also:

  • hardens the associated groupActions
  • hardens sync updates
  • adds a missing db query
  • fixes some deps issues on other queries
  • and fixes some UI bugs having to do with actually rendering the channels in the right order (according to the index we have on the backend)

Note:

  • For now we've disabled the section moving arrows (I added "Edit" and "Delete" buttons on the section title row, though)
  • The "default" section (which we currently call "Sectionless") appears at the bottom of the list since this is actually where it appears in the GroupChannelsScreen. If we wanna change that in both places to match the ochre design showing it at the top, with the "Default section" title, that's fine by me.

Looks like this on desktop:
image

Looks like this on mobile:

Simulator.Screen.Recording.-.iPhone.15.-.default.-.2025-01-08.at.16.30.06.mp4

Copy link

linear bot commented Jan 8, 2025

@patosullivan patosullivan marked this pull request as draft January 8, 2025 22:37
@patosullivan
Copy link
Member Author

Just noticed I need to clean up a bit around adding a new section, converting to draft for now.

@patosullivan patosullivan marked this pull request as ready for review January 9, 2025 15:30
@patosullivan
Copy link
Member Author

Ok, should be good to go now.

Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just some logging questions

Copy link
Member

@jamesacklin jamesacklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad at all, looks really nice!

@patosullivan patosullivan merged commit 3322871 into develop Jan 10, 2025
1 check passed
@patosullivan patosullivan deleted the po/tlon-3340-refine-manage-channels-screen branch January 10, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants