Cross-implementation decisions may be differentiators #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidben
reviewed
Oct 10, 2023
|
@davidben would you like to see changes here, or can we merge this? @dennisjackson, I'd also appreciate your review. |
cjpatton
approved these changes
Oct 13, 2023
Co-authored-by: Christopher Patton <[email protected]>
chris-wood
commented
Oct 13, 2023
cjpatton
reviewed
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #512
The idea here is that some real and fake ECH differentiator mitigations may require different implementations to agree on how things are done, which is out of scope. This PR also cleans up some text in the Do Not Stick Out section.
cc @dennisjackson, @davidben, @cjpatton