Minor editorial issues and fixing metadata to stop annoying make errors. #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's nothing wrong with "First"..."later". I don't think we should change these. |
ekr
requested changes
Nov 15, 2023
| @@ -1424,7 +1430,7 @@ consideration when reasoning about the privacy properties that ECH provides. | |||
|
|
|||
| ECH requires encrypted DNS to be an effective privacy protection mechanism. | |||
| However, verifying the server's identity from the Certificate message, | |||
| particularly when using the X509 CertificateType, may result in additional | |||
| particularly when using the X.509 CertificateType, may result in additional | |||
There was a problem hiding this comment.
This is not correct. Yes, they are X.509 certificates, but the name of the enum in RFC 8446 (S 4.4.2i) ix "X509"
Suggested change
| particularly when using the X.509 CertificateType, may result in additional | |
| particularly when using the X509 CertificateType, may result in additional |
|
I have fixed the metadata issue in #599. As noted above, I don't believe the proposed text changes are necessary/right and as they are within editorial discretion, I am closing the PR unmerged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the latter, I get the warning that I don't know how to fix