fix(expect-single-argument): fix error when providing no arguments an… #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
KayKadner
reviewed
Sep 18, 2024
lib/rules/expect-single-argument.js
Outdated
| @@ -14,7 +14,7 @@ function create (context) { | |||
| message: 'Expect must have a single argument. More than one argument were provided.', | |||
| node | |||
| }) | |||
| } else if (node.arguments.length === 0 && node.parent.property.name !== 'nothing') { | |||
| } else if (node.arguments.length === 0 && node.parent?.property?.name !== 'nothing') { | |||
There was a problem hiding this comment.
I think the parent-? is not needed, as the CallExpression is always child of something, at least an ExpressionStatement. But it also does not hurt. The property-? fixes it.
There was a problem hiding this comment.
It is indeed unnecessary. I've removed the optional chaining operator after the parent.
TimZM
changed the title
TimZM
force-pushed
the
fix/expect-single-argument-without-matcher
branch
from
ef2c10c to
f74d579
Compare
tlvince
approved these changes
Sep 18, 2024
|
🎉 This PR is included in version 4.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change to the expect-single-argument rule in #373 crashes when you have an expect without a matcher, as pointed out by KayKadner on that PR. By using optional chaining this rule can now handle expect without a subsequent matcher.
How has this been tested?
I've added tests for cases where there is no matcher. These indeed threw an error before applying the fix in this PR.
Types of changes
Checklist
npm run testand everything passes