-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbind issues on CRAN #113
Comments
First, thank you for your work on the units package. The units package is
fantastic and a big improvement over "the old days".
I am "very close" to having a new version of Rdistance submitted to CRAN
(branch 's6methods' of the Rdistance github repo). The changes in version
4.0.0 of Rdistance are extensive and are taking some time; but, I have
probably already fixed this rbind issue. I should be able to get a new
version of Rdistance on Cran in a few weeks.
…On Sun, Jan 19, 2025 at 8:51 AM Iñaki Ucar ***@***.***> wrote:
Dear maintainer,
We are preparing units 0.8-6 for release. I'm writing to you because our
revdep checks report new issues in your package with this new version (you
can check them here
<https://github.com/r-quantities/units/blob/main/revdep/problems.md#rdistance>
).
These issues are most probably caused by the recent addition of the
cbind.units and rbind.units methods. Binding a mix of units and non-units
objects won't work anymore. So it's important to properly add/drop units
for all objects involved. However, I see that your package is at v3.1.2
here, and I see many errors that are different from what I got for the CRAN
version.
We would appreciate if you could implement the proper fixes and send an
update to CRAN as time permits.
—
Reply to this email directly, view it on GitHub
<#113>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEZRTGNKGFMYH2L2GHMSPL2LPCXBAVCNFSM6AAAAABVO2IQFOVHI2DSMVQWIX3LMV43ASLTON2WKOZSG44TONRZGQ2DGNI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
[image: Logo] <https://mcdonalddatasciences.com/>
Trent McDonald, Ph.D. | President and Founder
*McDonald Data Sciences, LLC*Clear, Concise, Cutting-edge Analyses
w: mcdonalddatasciences.com <http://mcdonalddatasciences.com/>
p: 307.760.4721
|
Thanks, great news! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dear maintainer,
We are preparing units 0.8-6 for release. I'm writing to you because our revdep checks report new issues in your package with this new version (you can check them here).
These issues are most probably caused by the recent addition of the
cbind.units
andrbind.units
methods. Binding a mix of units and non-units objects won't work anymore. So it's important to properly add/drop units for all objects involved. However, I see that your package is at v3.1.2 here, and I see many errors that are different from what I got for the CRAN version.We would appreciate if you could implement the proper fixes and send an update to CRAN as time permits.
The text was updated successfully, but these errors were encountered: