Skip to content

Commit

Permalink
Convert Harpy Singing Into a Trait (Simple-Station#714)
Browse files Browse the repository at this point in the history
# Description
Adds a new trait that lets characters play midi without needing an
instrument.

Singer a 1-point positive trait. For now it's only available for vulps
and felinids as they are naturally more vocal than other species.

Also refactored harpy singing system a bit.

# TODO

- [X] Find out whatever causes this. Not critical, but probably should
be fixed...
<details><p>


![image](https://github.com/user-attachments/assets/8e0a6bf5-5fa3-4a0a-8937-2931dfe4ee62)

</p></details>

<details><summary><h1>Media</h1></summary>
<p>

Outdated


![image](https://github.com/user-attachments/assets/018b6cf3-d510-46e2-8c38-4bd49e1929bd)


![image](https://github.com/user-attachments/assets/f27bd451-b3c2-4a22-ab50-35c2f4ecbcb3)

</p>
</details>

# Changelog
:cl:
- add: Added a new positive trait - singer. It allows you to play midi
songs without an instrument, similarly to harpies.

---------

Signed-off-by: Mnemotechnican <[email protected]>
Co-authored-by: Danger Revolution! <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
  • Loading branch information
3 people authored and tim-mcqueen-ttec committed Aug 24, 2024
1 parent 84f9bf6 commit 90df0b1
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Resources/Locale/en-US/traits/traits.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -188,3 +188,5 @@ trait-description-WeaponsGeneralist =
You are a jack of all trades with melee weapons, enabling you to be versatile with your weapon arsenal.
Your melee damage bonus for all Brute damage types (Blunt, Slash, Piercing) becomes 25%.
trait-name-Singer = Singer
trait-description-Singer = You are naturally capable of singing simple melodies with your voice.
13 changes: 13 additions & 0 deletions Resources/Prototypes/Traits/skills.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,16 @@
inverted: true
species:
- Felinid

- type: trait
id: Singer
category: Auditory
points: -1
requirements:
- !type:CharacterSpeciesRequirement
inverted: true
species:
- Harpy
components:
- type: Singer
proto: NormalSinger

0 comments on commit 90df0b1

Please sign in to comment.