forked from macournoyer/ruby_http_parser
-
Notifications
You must be signed in to change notification settings - Fork 43
JRuby: Revert unimplemented "status" support and fix an failed test #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tests are fixed by #63 but still following 4 tests are failed:
|
Although there are still 3 failed tests, I'll merge this branch to master. |
This reverts commit 68e549f. Because it's not implemented in http-parser.java. How was it tested? It may be revived later when we implement it in our forked version. Signed-off-by: Takuro Ashie <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
Signed-off-by: Takuro Ashie <[email protected]>
In CRuby, they are ASCII_8BIT since they are created by rb_str_new(). On the other hand, they are UTF-8 in JRuby. Fix the following failed test on JRuby: 4) HTTP::Parser should parse request: utf-8 path request Failure/Error: expect(@parser.send("request_url")).to eq(test["request_url"].force_encoding(Encoding::BINARY)) expected: "/\xCE\xB4\xC2\xB6/\xCE\xB4t/pope?q=1#narf" got: "/δ¶/δt/pope?q=1#narf" (compared using ==) # ./spec/parser_spec.rb:387:in `block in <main>' Although they should use same encoding, I don't fix it for now to keep backward compatibility. Signed-off-by: Takuro Ashie <[email protected]>
c8e803f
to
1d76de1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.