Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from free-functions to class structure #6

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

coatless
Copy link
Contributor

@coatless coatless commented Dec 5, 2019

The PR implements logic to move toward C++ classes for each estimation model.

This simplifies passes and improves handling of each routine.

  expression          min   median `itr/sec` mem_alloc `gc/sec` n_itr  n_gc total_time 
  <bch:expr>     <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl> <int> <dbl>   <bch:tm> 
1 free_functions    13.6s    13.6s    0.0736   10.44MB   0.147      2     4      27.2s 
2 class_str         12.7s    13.6s    0.0739    4.46MB   0.0185     4     1      54.1s 

The class version has a lower memory consumption compared to the free function variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant