Fix #7 #28 #31 Propose an option to automatically turn on logging for… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to automatically turn on logging for new panes
|
Sorry about that. As I'm starting to use this code for my deployments I'm now noticing a lot of side effects when launching programs headless in a detached session... (suspect characters output on the host shell, empty logs with detached sessions, etc...) I'm therefore closing the pull request without merging it. I may come back later with a better and more tested proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #7 #28 and #31 by introducing a new
@start-logging-with-new-sessionparameter to the tmux config.When this parameter is set to "true" then
logging.tmuxwill try to hook a call tostart_logging.shwhenever a new session is spawned.I had to move a handful of functions to
scripts/shared.sh.This patch has a drawback: when the hook is set, then
start_logging.shdisplays a message to indicate the log file and nothing happen until this message is cleared. It introduces a timeout at session start that may be a show-stopper for some users.I don't know any elegant and efficient way of getting around this "bug".