Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment debug #23

Merged
merged 6 commits into from
Mar 20, 2024
Merged

fix comment debug #23

merged 6 commits into from
Mar 20, 2024

Conversation

tnyo43
Copy link
Owner

@tnyo43 tnyo43 commented Mar 20, 2024

add messages

  • if number of comments is less than the threshold ... "It's not necessary to send a recommending comment yet."
  • if it posts a comment ... "a recommending comment has been posted: #{comment url}"
  • if a recommending comment has already been sent ... "a recommending comment has already been posted: #{comment url}"

Repository owner deleted a comment from github-actions bot Mar 20, 2024
@tnyo43 tnyo43 mentioned this pull request Mar 20, 2024
Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment 1


showed message that recommending comment is not needed yet 👍

******* DEBUG is ENABLED *******
option {
token: '***',
prNumber: 23,
threshold: 4,
debug: true
}
number of the obtained comments is 1
It's not necessary to send a recommending comment yet.
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8361118686/job/22888426490

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment 2

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment 3

Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment 4


showed a message that a recommending comment is posted 👍

******* DEBUG is ENABLED *******
option {
token: '***',
prNumber: 23,
threshold: 4,
debug: true
}
number of the obtained comments is 4
a recommending comment has been posted: h\ttps://github.com/tnyo43/recommend-mobpro-action/pull/23#issuecomment-2009785989
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8361154113/job/22888547437

Copy link

Hey @tnyo43!

It seems the discussion is dragging on. Perhaps instead of text communication, you could try having a conversation via face-to-face or video call, or even try mob programming?

Copy link
Owner Author

@tnyo43 tnyo43 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment 5


showed a message that a recommending comment has been already been posted 👍

******* DEBUG is ENABLED *******
option {
token: '***',
prNumber: 23,
threshold: 4,
debug: true
}
a recommending comment has already been posted: h\ttps://github.com/tnyo43/recommend-mobpro-action/pull/23#issuecomment-2009785989
https://github.com/tnyo43/recommend-mobpro-action/actions/runs/8361203552/job/22888707267

@tnyo43 tnyo43 merged commit 3d10fb3 into main Mar 20, 2024
7 checks passed
@tnyo43 tnyo43 deleted the fix-comment-debug branch March 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant