Removes blur from frontend-egui
#5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes some `clippy` warnings.
This will allow more key types to be displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I came across Fearless-NES I was disappointed to find out that the display seemed blurry when running the native egui client. After some digging I found out that the issue lay with the actual egui_glium implementation. As discussed in this issue, egui_glium 0.19.0 ignores the
TextureFilterwhich is supposed to make things crisp. This is addressed in this commit although it has not made it into the current 0.19.0 release. What I did is simply change the version of egui_glium inCargo.tomlto have the fix from the commit. This does mean we are using an unreleased version of egui_glium, though I have yet to come across any issues. Besides, I doubt there are any as major as the current error. The emulator looks borderline unplayable in retrospect.