Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle covert leaves differently #3

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Handle covert leaves differently #3

merged 6 commits into from
Sep 5, 2023

Conversation

lynn
Copy link
Collaborator

@lynn lynn commented Sep 5, 2023

  • Get rid of leaf.word === 'functional'
    • It was mostly just a hack added to not draw ∅ under a 𝘷.
  • If leaf.word === 'covert', then leaf.value says what the "covert value" is.
    • Right now the possibilities are (a generic null), BE (non-agentive 𝘷), CAUSE (agentive 𝘷), and PRO.
  • Get rid of the hacky 𝘷0 label, in favor of {label: '𝘷', word: 'covert', value: 'BE'}.
  • "Plain" 𝘷 is now {label: '𝘷', word: 'covert', value: 'CAUSE'}.

@lynn lynn requested a review from robintown September 5, 2023 19:48
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with one suggestion (and go ahead with the covert: boolean approach if you want)

src/semantics/denote.ts Outdated Show resolved Hide resolved
@lynn lynn merged commit 5b87382 into main Sep 5, 2023
4 checks passed
@robintown robintown deleted the no-functional branch September 5, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants