Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post processing: Merge/Split of tracked cells. #134

Closed
wants to merge 6 commits into from

Conversation

kelcyno
Copy link
Collaborator

@kelcyno kelcyno commented Jun 2, 2022

This branch introduces the merge/split framework. This also introduces the standardized dataset in which the track, segmentation mask, and feature datasets are combined. Below is an example of the merge/split call, the standardized track dataset usage, and an example of these two datasets being merged. We include in the merge_split.py file a quick compression, which is also shown in the example blow.

d = merge_split(Track)
ds = standardize_track_dataset(Track, refl_mask, data['ProjectionCoordinateSystem'])
both_ds = xr.merge([ds, d],compat ='override')
both_ds = compress_all(both_ds)

kelcyno and others added 4 commits February 18, 2022 13:15
@freemansw1 freemansw1 added the enhancement Addition of new features, or improved functionality of existing features label Jun 3, 2022
@freemansw1 freemansw1 added this to the Version 1.5 milestone Jun 3, 2022
@freemansw1
Copy link
Member

Thanks for submitting this PR, @kelcyno . It looks like you reverted the split/merge changes, so they don't appear in here. Also, it looks like the isolation changes from #76 are in here too; was that intentional, and is it needed for splits/merges to work? If so, happy to have these combined, but I'll close #76.

I've waited to assign reviewers to this PR for now. I'll likely assign myself and @JuliaKukulies to review this, ultimately.

This reverts commit 547bd2a.
Attempting to correct some incorrect merging. Should include only the merge_split.py file.
@kelcyno
Copy link
Collaborator Author

kelcyno commented Jun 6, 2022

@freemansw1 I believe I originally pushed on the wrong branch, then reverted. I just pushed the merge_split.py file, this is the only file needed for the merge/split, and the isolation changes are not needed for this to work.

@freemansw1
Copy link
Member

Ah, makes sense. Thanks for updating it. Given that the isolation changes aren't needed for this, my suggestion is to remove them from this PR and we can continue our discussion in #76, if that's okay with you. In the meantime, I've requested @JuliaKukulies and myself to review the PR, but I will wait to review until the isolation changes are removed (and I have more time).

Also- I'm not entirely sure why the Github actions aren't running here. I am a bit short on time at the moment, but I'll try to investigate in the next week or two.

Replaced former segmentation file with isolated feature changes.
@kelcyno
Copy link
Collaborator Author

kelcyno commented Jun 6, 2022

Alright - I updated the segmentation file to remove the isolation changes, using the default segmentation.py file. If this doesn't go smoothly let me know and I'll try deleting the branch and redoing the pull request with just the merge_split.py file.

@freemansw1
Copy link
Member

Hm- I still see the segmentation changes in there. Can you try pushing again with them removed? Also, can you remove the file in the Build directory?

@kelcyno kelcyno closed this Jun 6, 2022
@kelcyno kelcyno deleted the merge_split branch June 6, 2022 21:23
@freemansw1 freemansw1 removed this from the Version 1.5 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants