Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.5.1 release updates #325

Merged

Conversation

w-k-jones
Copy link
Member

Update version number, changelog and notebooks for v1.5.1 release

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@w-k-jones w-k-jones added the release Organising the next release on conda-forge label Aug 15, 2023
@w-k-jones w-k-jones added this to the Version 1.5.x milestone Aug 15, 2023
@w-k-jones w-k-jones self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (2175cd2) 55.84% compared to head (411328c) 55.84%.

Additional details and impacted files
@@               Coverage Diff               @@
##           RC_v1.5_hotfix     #325   +/-   ##
===============================================
  Coverage           55.84%   55.84%           
===============================================
  Files                  15       15           
  Lines                3302     3302           
===============================================
  Hits                 1844     1844           
  Misses               1458     1458           
Flag Coverage Δ
unittests 55.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tobac/__init__.py 92.30% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for taking care of this hotfix, @w-k-jones! I assume that we should merge this before #323.

One thing I noticed is that you called the new hotfix branch RC_v1.5_hotfix which has the same branch pattern that we use for the release candidates (RC_v*). That is not a big deal at all, but I just wanted to point out this because it means that the branch falls under the branch protection rules for release candidates (2 reviews) now.

Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, Will.

@w-k-jones
Copy link
Member Author

One thing I noticed is that you called the new hotfix branch RC_v1.5_hotfix which has the same branch pattern that we use for the release candidates (RC_v*). That is not a big deal at all, but I just wanted to point out this because it means that the branch falls under the branch protection rules for release candidates (2 reviews) now.

I did that specifically so that the branch protection rules would apply, but perhaps we should consider in future a different workflow for hotfixes?

@w-k-jones w-k-jones merged commit bcfc827 into tobac-project:RC_v1.5_hotfix Aug 15, 2023
@w-k-jones w-k-jones mentioned this pull request Aug 15, 2023
8 tasks
@JuliaKukulies
Copy link
Member

One thing I noticed is that you called the new hotfix branch RC_v1.5_hotfix which has the same branch pattern that we use for the release candidates (RC_v*). That is not a big deal at all, but I just wanted to point out this because it means that the branch falls under the branch protection rules for release candidates (2 reviews) now.

I did that specifically so that the branch protection rules would apply, but perhaps we should consider in future a different workflow for hotfixes?

Ah OK :) I thought that we had agreed at some point that one review suffices for hotfixes, but we can re-evaluate if this really should be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Organising the next release on conda-forge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants