-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1.5.1 release updates #325
V1.5.1 release updates #325
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5_hotfix #325 +/- ##
===============================================
Coverage 55.84% 55.84%
===============================================
Files 15 15
Lines 3302 3302
===============================================
Hits 1844 1844
Misses 1458 1458
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for taking care of this hotfix, @w-k-jones! I assume that we should merge this before #323.
One thing I noticed is that you called the new hotfix branch RC_v1.5_hotfix
which has the same branch pattern that we use for the release candidates (RC_v*
). That is not a big deal at all, but I just wanted to point out this because it means that the branch falls under the branch protection rules for release candidates (2 reviews) now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, Will.
I did that specifically so that the branch protection rules would apply, but perhaps we should consider in future a different workflow for hotfixes? |
Ah OK :) I thought that we had agreed at some point that one review suffices for hotfixes, but we can re-evaluate if this really should be the case. |
Update version number, changelog and notebooks for v1.5.1 release