Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful handling of Numba import errors #335

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Graceful handling of Numba import errors #335

merged 3 commits into from
Sep 14, 2023

Conversation

freemansw1
Copy link
Member

@freemansw1 freemansw1 commented Sep 8, 2023 •
edited
Loading

Resolves #332 and handles numba import errors more gracefully

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 changed the base branch from main to RC_v1.5.x September 8, 2023 15:56
@freemansw1 freemansw1 added this to the Version 1.5.x milestone Sep 8, 2023
@freemansw1 freemansw1 added the bug Code that is failing or producing the wrong result label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (6b573c0) 55.74% compared to head (bfeac44) 55.75%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           RC_v1.5_hotfix     #335   +/-   ##
===============================================
  Coverage           55.74%   55.75%           
===============================================
  Files                  15       15           
  Lines                3310     3313    +3     
===============================================
+ Hits                 1845     1847    +2     
- Misses               1465     1466    +1
Flag Coverage Δ
unittests 55.75% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tobac/utils/internal.py 87.67% <75.00%> (-0.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freemansw1 freemansw1 changed the base branch from RC_v1.5.x to RC_v1.5_hotfix September 8, 2023 18:11
@freemansw1 freemansw1 mentioned this pull request Sep 8, 2023
Merged
11 tasks
@freemansw1
Copy link
Member Author

I will re-request reviews after #336 is merged

@freemansw1 freemansw1 mentioned this pull request Sep 8, 2023
Closed
@freemansw1
Copy link
Member Author

@JuliaKukulies @kelcyno @w-k-jones I've resolved the merge conflict and this is now ready for review.

JuliaKukulies
JuliaKukulies approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@freemansw1
Copy link
Member Author

I'm not sure why the notebooks are failing, but the action seems to be failing at the installing dependencies step.

@freemansw1
Copy link
Member Author

Will wait on #340 to merge/re-review

@freemansw1
Copy link
Member Author

OK this is now ready for re-review @JuliaKukulies @w-k-jones @kelcyno

@freemansw1 freemansw1 merged commit 56994d2 into tobac-project:RC_v1.5_hotfix Sep 14, 2023
7 checks passed
@freemansw1 freemansw1 mentioned this pull request Sep 14, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-k-jones w-k-jones w-k-jones approved these changes

@kelcyno kelcyno Awaiting requested review from kelcyno

@JuliaKukulies JuliaKukulies Awaiting requested review from JuliaKukulies

Assignees
No one assigned
Labels
bug Code that is failing or producing the wrong result
Projects
None yet
Milestone
Version 1.5.1
Development

Successfully merging this pull request may close these issues.

Handle numba errors more gracefully
3 participants
@freemansw1 @w-k-jones @JuliaKukulies