-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated docstrings for n_min_threshold #432
updated docstrings for n_min_threshold #432
Conversation
Linting results by Pylint:Your code has been rated at 8.70/10 (previous run: 8.70/10, +0.00) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #432 +/- ##
=============================================
+ Coverage 60.71% 60.91% +0.19%
=============================================
Files 23 23
Lines 3541 3541
=============================================
+ Hits 2150 2157 +7
+ Misses 1391 1384 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @JuliaKukulies .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Something I overlooked: it might be good to change the type hint to |
Thanks @fziegner! I have addressed your comments now and will merge once the tests have passed :) |
Solves #427