Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional calculation of bulk statistics in feature detection on raw input (before smoothing) #449

Merged

Conversation

JuliaKukulies
Copy link
Member

Addresses #440 and allows for the user to choose whether the bulk statistics in the feature detection are calculated on the unsmoothed or the smoothed input data.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.99%. Comparing base (3609a59) to head (132ea24).
Report is 36 commits behind head on RC_v1.5.x.

Files with missing lines Patch % Lines
tobac/feature_detection.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           RC_v1.5.x     #449      +/-   ##
=============================================
+ Coverage      60.96%   60.99%   +0.02%     
=============================================
  Files             23       23              
  Lines           3548     3553       +5     
=============================================
+ Hits            2163     2167       +4     
- Misses          1385     1386       +1     
Flag Coverage Δ
unittests 60.99% <83.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 20, 2024

Linting results by Pylint:

Your code has been rated at 8.73/10 (previous run: 8.73/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the RC_v1.5.x branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

@JuliaKukulies JuliaKukulies changed the title Bulk stats on raw input Optional calculation of bulk statistics in feature detection on raw input (before smoothing) Sep 20, 2024
@JuliaKukulies
Copy link
Member Author

Tests should be OK after merge of #451

@w-k-jones w-k-jones linked an issue Sep 25, 2024 that may be closed by this pull request
@JuliaKukulies
Copy link
Member Author

Something is going on with the formatting although I seem to use a compatible black version but I had some issue with pre-commit. Will figure it out soon hopefully!

@w-k-jones w-k-jones added the enhancement Addition of new features, or improved functionality of existing features label Sep 30, 2024
@w-k-jones w-k-jones linked an issue Sep 30, 2024 that may be closed by this pull request
@w-k-jones w-k-jones added this to the Version 1.5.4 milestone Sep 30, 2024
Copy link
Member

@freemansw1 freemansw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this, @JuliaKukulies . The one test failing isn't a concern.

@JuliaKukulies
Copy link
Member Author

OK, so merge ? :)

@JuliaKukulies JuliaKukulies merged commit d9f2df8 into tobac-project:RC_v1.5.x Oct 14, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculate Bulk Statistics from Raw Data
3 participants