-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional calculation of bulk statistics in feature detection on raw input (before smoothing) #449
Optional calculation of bulk statistics in feature detection on raw input (before smoothing) #449
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## RC_v1.5.x #449 +/- ##
=============================================
+ Coverage 60.96% 60.99% +0.02%
=============================================
Files 23 23
Lines 3548 3553 +5
=============================================
+ Hits 2163 2167 +4
- Misses 1385 1386 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Linting results by Pylint:Your code has been rated at 8.73/10 (previous run: 8.73/10, +0.00) |
Tests should be OK after merge of #451 |
Something is going on with the formatting although I seem to use a compatible black version but I had some issue with pre-commit. Will figure it out soon hopefully! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this, @JuliaKukulies . The one test failing isn't a concern.
OK, so merge ? :) |
d9f2df8
into
tobac-project:RC_v1.5.x
Addresses #440 and allows for the user to choose whether the bulk statistics in the feature detection are calculated on the unsmoothed or the smoothed input data.