Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues due to old conda version #465

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

freemansw1
Copy link
Member

This continues the work from #457 and fixes issues with a few of our CI workflows that broke from miniconda being depreciated.

Note that this is a PR to main per our policy of CI improvements

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.67%. Comparing base (343243f) to head (203e4fd).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   60.72%   60.67%   -0.06%     
==========================================
  Files          23       23              
  Lines        3537     3537              
==========================================
- Hits         2148     2146       -2     
- Misses       1389     1391       +2     
Flag Coverage Δ
unittests 60.67% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@freemansw1
Copy link
Member Author

The notebook CI is failing due to an upstream issue with pyart that has been fixed and will be released as part of their next version (ARM-DOE/pyart#1623). As a temporary fix, I've copied their fix over to pin xarray versions to <2024.10.0.

I have no clue what is happening to the lining workflow. I've tried to partially roll it back, but it seems to always grab the old version of the file. I'd appreciate some help here, if someone wants to take a look.

@freemansw1
Copy link
Member Author

I have no clue what is happening to the lining workflow. I've tried to partially roll it back, but it seems to always grab the old version of the file. I'd appreciate some help here, if someone wants to take a look.

Okay, apparently this is expected behavior: https://github.com/orgs/community/discussions/122045 . I suppose we just must trust that the CI will pass?

@freemansw1 freemansw1 mentioned this pull request Nov 1, 2024
11 tasks
@freemansw1 freemansw1 mentioned this pull request Nov 4, 2024
11 tasks
Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for sorting this! Happy to merge and see if the linting works properly afterwards

Copy link
Member

@JuliaKukulies JuliaKukulies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes OK, good to go from my side and merge this and see if the linting issue will fix itself. Thanks for fixing this, @freemansw1 !

@freemansw1 freemansw1 merged commit 706b3ee into tobac-project:main Nov 8, 2024
23 of 24 checks passed
@freemansw1 freemansw1 mentioned this pull request Nov 8, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants