-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues due to old conda version #465
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 60.72% 60.67% -0.06%
==========================================
Files 23 23
Lines 3537 3537
==========================================
- Hits 2148 2146 -2
- Misses 1389 1391 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The notebook CI is failing due to an upstream issue with pyart that has been fixed and will be released as part of their next version (ARM-DOE/pyart#1623). As a temporary fix, I've copied their fix over to pin xarray versions to I have no clue what is happening to the lining workflow. I've tried to partially roll it back, but it seems to always grab the old version of the file. I'd appreciate some help here, if someone wants to take a look. |
Okay, apparently this is expected behavior: https://github.com/orgs/community/discussions/122045 . I suppose we just must trust that the CI will pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for sorting this! Happy to merge and see if the linting works properly afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes OK, good to go from my side and merge this and see if the linting issue will fix itself. Thanks for fixing this, @freemansw1 !
This continues the work from #457 and fixes issues with a few of our CI workflows that broke from
miniconda
being depreciated.Note that this is a PR to main per our policy of CI improvements