Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Documentation Revamp and Retheme #470

Open
wants to merge 4 commits into
base: dev_documentation_revamp
Choose a base branch
from

Conversation

freemansw1
Copy link
Member

After #460, I started to poke around to figure out how to make things look better on our documentation. As it turns out, making the docs look and feel modern was really not all that much work. I also thought v1.6.0 would be an ideal time to produce new, modern-feeling documentation.

This represents just a first step. I have modified very little text, instead just reorganizing things into categories to fit the theme. Note that this is requested to be merged into a new dev_documentation_revamp branch, which comes off RC_v1.6.0. I'm putting this in a branch by itself to encourage more collaborative work on this; perhaps we can commit to that repo directly rather than doing it through PRs (until it is time to merge into the RC).

Given the somewhat unusual path here, I'm requesting relatively light reviews. We will continue to make updates before merging into the RC, I am at this point just seeking feedback on whether or not this is broadly fits what we are looking to do with our documentation.

  • Have you followed our guidelines in CONTRIBUTING.md?
  • Have you self-reviewed your code and corrected any misspellings?
  • Have you written documentation that is easy to understand?
  • Have you written descriptive commit messages?
  • Have you added NumPy docstrings for newly added functions?
  • Have you formatted your code using black?
  • If you have introduced a new functionality, have you added adequate unit tests?
  • Have all tests passed in your local clone?
  • If you have introduced a new functionality, have you added an example notebook?
  • Have you kept your pull request small and limited so that it is easy to review?
  • Have the newest changes from this branch been merged?

@freemansw1 freemansw1 added enhancement Addition of new features, or improved functionality of existing features documentation Updates and improvements to documentation and examples labels Nov 15, 2024
@freemansw1 freemansw1 added this to the Version 1.6 milestone Nov 15, 2024
@freemansw1 freemansw1 self-assigned this Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Linting results by Pylint:

Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00)
The linting score is an indicator that reflects how well your code version follows Pylint’s coding standards and quality metrics with respect to the dev_documentation_revamp branch.
A decrease usually indicates your new code does not fully meet style guidelines or has potential errors.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.27%. Comparing base (0ebee82) to head (0cecc40).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           dev_documentation_revamp     #470   +/-   ##
=========================================================
  Coverage                     62.27%   62.27%           
=========================================================
  Files                            23       23           
  Lines                          3690     3690           
=========================================================
  Hits                           2298     2298           
  Misses                         1392     1392           
Flag Coverage Δ
unittests 62.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@w-k-jones w-k-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Happy for this to be merged into the docs development branch so further work can get started. Some thoughts, which can be addressed in later PRs:

  • API documentation has no subsections in the left side column
  • The home page is a bit unclear now, as it is just a block of text. We should think about how to restructure it to more clearly direct users to the info they need. I quite like the way that the numpy and xarray docs homepage is structured

@freemansw1
Copy link
Member Author

Looks really good! Happy for this to be merged into the docs development branch so further work can get started. Some thoughts, which can be addressed in later PRs:

  • API documentation has no subsections in the left side column

Yeah, I'll plan to fix that before the PR gets merged. Good call. I need to dig into that section some more.

  • The home page is a bit unclear now, as it is just a block of text. We should think about how to restructure it to more clearly direct users to the info they need. I quite like the way that the numpy and xarray docs homepage is structured

One reason I didn't do anything to the homepage is that I am not sure whether we should go for something like the xarray/numpy/metpy documentation or more of a highlight gallery like the ArviZ documentation (https://python.arviz.org/en/stable/). I am inclined for the latter, but I am open to either.

@fsenf
Copy link
Member

fsenf commented Dec 6, 2024

Nice look! I really like it. Well done, @freemansw1 !

A few minor comments:

  • could we get rid of "Section Navigation":
    grafik

  • user guide starts empty:
    grafik

  • (I have issues to understand the hierarchy at the moment, I mean chapter -> section -> subsection, but this may come with time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Updates and improvements to documentation and examples enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants