-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Documentation Revamp and Retheme #470
base: dev_documentation_revamp
Are you sure you want to change the base?
Feature: Documentation Revamp and Retheme #470
Conversation
Linting results by Pylint:Your code has been rated at 8.72/10 (previous run: 8.72/10, +0.00) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_documentation_revamp #470 +/- ##
=========================================================
Coverage 62.27% 62.27%
=========================================================
Files 23 23
Lines 3690 3690
=========================================================
Hits 2298 2298
Misses 1392 1392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Happy for this to be merged into the docs development branch so further work can get started. Some thoughts, which can be addressed in later PRs:
- API documentation has no subsections in the left side column
- The home page is a bit unclear now, as it is just a block of text. We should think about how to restructure it to more clearly direct users to the info they need. I quite like the way that the numpy and xarray docs homepage is structured
Yeah, I'll plan to fix that before the PR gets merged. Good call. I need to dig into that section some more.
One reason I didn't do anything to the homepage is that I am not sure whether we should go for something like the xarray/numpy/metpy documentation or more of a highlight gallery like the ArviZ documentation (https://python.arviz.org/en/stable/). I am inclined for the latter, but I am open to either. |
Nice look! I really like it. Well done, @freemansw1 ! A few minor comments: |
After #460, I started to poke around to figure out how to make things look better on our documentation. As it turns out, making the docs look and feel modern was really not all that much work. I also thought v1.6.0 would be an ideal time to produce new, modern-feeling documentation.
This represents just a first step. I have modified very little text, instead just reorganizing things into categories to fit the theme. Note that this is requested to be merged into a new
dev_documentation_revamp
branch, which comes offRC_v1.6.0
. I'm putting this in a branch by itself to encourage more collaborative work on this; perhaps we can commit to that repo directly rather than doing it through PRs (until it is time to merge into the RC).Given the somewhat unusual path here, I'm requesting relatively light reviews. We will continue to make updates before merging into the RC, I am at this point just seeking feedback on whether or not this is broadly fits what we are looking to do with our documentation.