Add count of neighboring cells #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just updated this to merging into v2.0-dev branch, which seems to have cleared up all the conflicts. I'll review and merge once I get the chance, but it all looks fine at first glance |
freemansw1
reviewed
Feb 17, 2022
| @@ -31,17 +31,20 @@ def check_isolation(raw, filtered, grid_size, params): | |||
| params['ISO_THRESH']) | |||
| nobj_iso = np.max(iso_filtered) | |||
| iso = np.empty(nobj, dtype='bool') | |||
| neighbors = np.ones(nobj)*(-9999) | |||
There was a problem hiding this comment.
Why is this set to -9999? I'm not that familiar with the tint code yet, so if there's something obvious, let me know. Trying to figure out missing data vs. 0 neighbors; is this better as 0?
|
Converted this to a draft, as this change is outdated with our current development |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the number of neighboring objects to the the function check_isolation instead of just returning true or false for a cell. The addition of this metric in the final xrarray output was suggested by Jiaxi Hu and @deeplycloudy.