Use blacklist instead of internal emit function

tobiasmuecksch · Jun 13, 2014 · be3f3c4 · be3f3c4
1 parent f15104d
commit be3f3c4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/lib/manager.js b/lib/manager.js
@@ -64,7 +64,7 @@ function Manager(uri, opts){
 Manager.prototype.propagateEvent = function() {
   this.emit.apply(this, arguments);
   for (var nsp in this.nsps) {
-    this.nsps[nsp].$emit.apply(this.nsps[nsp], arguments);
+    this.nsps[nsp].emit.apply(this.nsps[nsp], arguments);
   }
 };
 
@@ -452,5 +452,5 @@ Manager.prototype.onreconnect = function(){
   var attempt = this.attempts;
   this.attempts = 0;
   this.reconnecting = false;
-  this.emit('reconnect', attempt);
+  this.propagateEvent('reconnect', attempt);
 };
diff --git a/lib/socket.js b/lib/socket.js
@@ -28,7 +28,12 @@ module.exports = exports = Socket;
 var events = {
   connect: 1,
   disconnect: 1,
-  error: 1
+  error: 1,
+  reconnect: 1,
+  reconnect_attempt: 1,
+  reconnect_failed: 1,
+  reconnect_error: 1,
+  reconnecting: 1
 };
 
 /**
@@ -96,15 +101,6 @@ Socket.prototype.send = function(){
   return this;
 };
 
-/**
- * EventEmitter#emit for internal events
- *
- * @api private
- */
-Socket.prototype.$emit = function(ev) {
-  emit.apply(this, arguments);
-};
-
 /**
  * Override `emit`.
  * If the event is in `events`, it's emitted normally.