Update the Electron wrapper #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal set of changes, not a refactor yet. Make shapez store all of its data in a single directory whose path is provided by Electron APIs. Useless checks and web preferences are removed and app.isPackaged is used to detect whether the app should try to load a localhost URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some things that annoyed me, such as inconsistent data storage (using Electron default directory for browser data, but custom one for mods and savegames) or relying on a
--localflag to load localhost URL. I also removed most web preferences as they had the default values and some of the events that didn't exist anymore or would never be fired.