[1844] Consider lowest cost variant for buy_train step actions

tobymao · Oct 17, 2024 · f229cc9 · f229cc9
1 parent b9fd70a
commit f229cc9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/lib/engine/train.rb b/lib/engine/train.rb
@@ -107,9 +107,12 @@ def id
     # if set ability must be a :train_discount ability
     def min_price(ability: nil)
       return 1 unless from_depot?
-      return @price unless ability
 
-      Array(ability).map { |a| a.discounted_price(self, @price) }.min
+      variants.keys.map do |v|
+        variant = clone
+        variant.variant = v
+        Array(ability).map { |a| a.discounted_price(variant, variant.price) }.min || variant.price
+      end.min
     end
 
     def from_depot?

diff --git a/public/fixtures/1844/160062.json b/public/fixtures/1844/160062.json
diff --git a/public/fixtures/1844/164302.json b/public/fixtures/1844/164302.json