Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18NY] Change Text for Forced Salvage of Trains Over Limit on Phase Change #9128

Open
djanyreason opened this issue Apr 19, 2023 · 3 comments · Fixed by #9136 · May be fixed by #11322
Open

[18NY] Change Text for Forced Salvage of Trains Over Limit on Phase Change #9128

djanyreason opened this issue Apr 19, 2023 · 3 comments · Fixed by #9136 · May be fixed by #11322
Assignees
@benjaminxscott
Labels
enhancement New feature or request

Comments

@djanyreason
Copy link

djanyreason commented Apr 19, 2023 •
edited by benjaminxscott
Loading

In 18NY, when a phase change triggers a drop in train limit the UI prompts the player to choose a train to discard. However, the player is actually choosing which train to salvage, and gets the salvage value for the train. I would suggest changing the text to prompt to choose the train to 'salvage', not to 'discard'.
@djanyreason djanyreason added the enhancement New feature or request label Apr 19, 2023
@benjaminxscott benjaminxscott self-assigned this Apr 21, 2023
@benjaminxscott
Copy link
Contributor

benjaminxscott commented Apr 21, 2023 •
edited
Loading

Do you have a sample game for this?

I don't play 18NY, I looked at your active/old games but didn't see the specific 'discard due to train limit' action (I do see salvaging as a player choice and as part of phase switch rusting)

https://18xx.games/?title=18NY

@djanyreason
Copy link
Author

Here's a link to the action that inspired the suggestion: https://18xx.games/game/118662?action=523

@benjaminxscott benjaminxscott mentioned this issue Apr 22, 2023
Merged
3 tasks
@benjaminxscott
Copy link
Contributor

as a note to myself, this change was reverted due to it breaking games broadly
4523b91

@philcampeau philcampeau linked a pull request Nov 5, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaminxscott benjaminxscott

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@benjaminxscott @djanyreason