Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18NY] Change Text for Forced Salvage of Trains Over Limit on Phase Change #9136

Merged
merged 1 commit into from
Apr 22, 2023
Merged

[18NY] Change Text for Forced Salvage of Trains Over Limit on Phase Change #9136

merged 1 commit into from
Apr 22, 2023

Conversation

benjaminxscott
Copy link
Contributor

@benjaminxscott benjaminxscott commented Apr 22, 2023 •
edited
Loading

Fixes #9128

Please minimize the amount of changes to shared lib/engine code, if possible

If you are implementing a new game, please break up the changes into multiple PRs for ease of review.

Before clicking "Create"

  • Branch is derived from the latest master
  • [NA] Add the pins label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

  • Explanation of Change

Generalizes the 'verb' that is used during a forced "discard train" step

Adds the salvage property to 18NY trains, as this is used to determine whether the verb will be "Salvage" or not

  • Screenshots
    Before:
    image

After:
Screenshot 2023-04-21 2 32 59 PM

  • Any Assumptions / Hacks

@michaeljb michaeljb added the Core touches shared code not limited to one game or game family label Apr 22, 2023
@michaeljb michaeljb merged commit bac6d14 into tobymao:master Apr 22, 2023
michaeljb added a commit that referenced this pull request Apr 22, 2023
@michaeljb
Revert "[18NY] Change Text for Forced Salvage of Trains Over Limit on…
4523b91 
… Phase Change"

This reverts commit 9fbdce8.

Reverts #9136.

Fixes #9137.
@michaeljb michaeljb mentioned this pull request Apr 22, 2023
Closed
@benjaminxscott benjaminxscott mentioned this pull request Apr 23, 2023
Closed
3 tasks
@philcampeau philcampeau mentioned this pull request Nov 5, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljb michaeljb michaeljb approved these changes

Assignees
No one assigned
Labels
Core touches shared code not limited to one game or game family
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[18NY] Change Text for Forced Salvage of Trains Over Limit on Phase Change
2 participants
@benjaminxscott @michaeljb