[SteamOverHolland] fixes train discount bug

[philcampeau]

Fixes #11163

Before clicking "Create"

• Branch is derived from the latest master
• Add the pins or archive_alpha_games label if this change will break existing games
• Code passes linter with docker compose exec rack rubocop -a
• Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Changes the emergency_issuable_bundles method to read @depot.min_price(ability: nil) instead of @depot.min_depot_price

I had to remove a fixture file that broke as a result. Also, this will break any alpha games with this private, and possibly all of them.

Screenshots

Any Assumptions / Hacks

[philcampeau]

I've just submitted a new commit, which seems to resolve the issue, and shouldn't break any games.

[ollybh]

I think that there might still be a potential bug lurking in here: part of the test at the start of Step::BuyTrain.must_sell_shares? is whether the corporation has more cash than the face value of the cheapest train. What happens if the corporation that owns the Werkspoor private has no train and between 90% and 100% the price of the cheapest train? Will they be able to sell shares, even though this isn't needed to buy the train.
You might need to change this test to use the Depot.min_price(corporation, ability) function.