[Core] Add subsidies to dividend step #11202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is not complete yet. Posting main code for feedback before I update affected game code. |
|
If you want to update 60/62 you will probably want to take to a look at app/view/game/run_routes as well. |
run_routes seemed to work out of the box when |
crericha
force-pushed
the
subsidy-in-dividend
branch
from
66acf9b to
14a7fee
Compare
crericha
requested review from
perwestling,
Zwergenpunk and
michaeljb
as code owners
perwestling
reviewed
Oct 9, 2024
perwestling
reviewed
Oct 9, 2024
|
I ran this branch against the entire db of games and no failures were found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add generic implementation of subsidies in the dividend step.
Previously, games that used subsidies, copy and pasted the subsidy logic into their dividend step. This PR moves that copy and pasted code into the base dividend step. If a game does not have a subsidy, the added logic has no effect.