Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18MS] Fixes M&M ability to only work for owning corp #11319

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

philcampeau
Copy link
Collaborator

Fixes #10025

Before clicking "Create"

  • Branch is derived from the latest master
  • Add the pins or archive_alpha_games label if this change will break existing games
  • Code passes linter with docker compose exec rack rubocop -a
  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

The M&M private was usable by any corporation that the president of the owning corporation was running. This was corrected by adding when: 'token' to the company in entities.rb, limiting its use to the owning corporation's token laying step.

Screenshots

Any Assumptions / Hacks

@ollybh ollybh added the 18MS label Nov 6, 2024
@ollybh ollybh added the pins PR that will require some games to be pinned label Dec 20, 2024
@ollybh ollybh merged commit 61c521f into tobymao:master Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18MS pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[18MS] M&M private allows token during another company's turn
2 participants