[1871] Prevents sale of more than 30% during EMR #11321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollybh
reviewed
Dec 15, 2024
Comment on lines
-62
to
-64
| # This is our new clause for 1871, if this is the corporation | ||
| # selling, we can sell all of them | ||
| return true if bundle.corporation == bundle.owner |
There was a problem hiding this comment.
Does removing this test change anything? Are there any bundles of treasury shares that would be rejected by the selling_miniumum_shares? test which should be issuable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8260
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rakeThis will likely require pins.
Implementation Notes
Explanation of Change
Players should not be able to sell more than 30% of a corp during funding, as per rule:
Corporations may issue above 30%, so I put in an added guard clause to ensure only players are blocked.
Screenshots
Any Assumptions / Hacks