[18Ardennes] Allow public companies to issue shares #11341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd completely missed the rule that public companies are allowed to issue shares to the open market, apart from on their first operating turn. This commit adds this step. Fixes tobymao#11221. This will break almost all 18Ardennes game. These can be fixed by the migrate games script, which will add passes for all the issue shares steps.
Issuing shares was occuring after a public company had grown up, but before the president was given the option to buy new shares or fold in minor companies. Issuing shares should be done after this.
If a public company had multiple shares in the bank pool then each one was being offered in exchange for minor companies, giving duplicated buttons. All the shares are identical, so just offer the first one for exchange.
ollybh
added
migrate_game
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Notes
I'd completely missed the rule that public companies are allowed to issue shares to the open market, apart from on their first operating turn. This pull request adds this step.
Fixes #11221.
This will break almost all 18Ardennes game. These can all be fixed by the default migrate games script, which will add passes for all the issue shares steps.
This pull request also fixes a bug (not reported on Github) where, when exchanging a minor company for a market share, one exchange button was being generated for each of the public company's shares in the open market. Just one button is needed.
Before clicking "Create"
masterpinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake